Fix what a full test round of today's releases found: a ticking single clock, a switch that works in standby, no taps from a swipe (0.2.78)
A test and code-analysis round of 0.2.72 to 0.2.76 (suites at every tag, sanitizers, ESP32 and GitHub builds, host harnesses on both boards, the editor in a browser, best practice checked against ESPHome, LVGL, Home Assistant and Vue) found these, fixed here with Max's choices for the product questions: - Firmware 0.2.65: the second hand of a single analog clock moves again; on a page that is one full on/off tile the waking push also switches it; on the Guition a flick is never a tap and a finger that slides off a tile doesn't tap it; Previous/Next react to a firm press; the same Go to page tile may sit on several pages; a layout the screen has no memory for is refused instead of crashing; 64-bit redraw mask for 48 tiles; Montserrat 14 no longer built. - App: Save refuses a layout too long for one message or too big for eight pages; an offline screen keeps its firmware version from the device registry; HA refusals reach the editor; 128 KB requests; changelog out of the live stream; cached hashed assets; tini as init and a clean stop; changelog parsing without asterisks or crashes. - Editor: clicking the open screen keeps unsaved edits, edits during a save stay unsaved, a Page row and phone dragging to other pages, repeated page tiles, limits from the server, HA's error messages, a type-checked build. - tools/check.sh + GitHub Actions + a CYD flash budget; docs match 48 tiles and the new editor. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
+28
-5
@@ -3,9 +3,11 @@
|
||||
# Source profile for packages/guition.yaml (tools/generate_packages.py); see docs/GUITION.md.
|
||||
# A screen gets its tiles from the ESP Screen Manager add-on while it runs. The CYD is its own profile.
|
||||
substitutions:
|
||||
SCREEN_FIRMWARE_VERSION: "0.2.64"
|
||||
# 0: no drift limit; LVGL decides, releasing inside the tile is a tap, leaving it is not
|
||||
# (like iOS). The CYD keeps a limit because its resistive panel jumps.
|
||||
SCREEN_FIRMWARE_VERSION: "0.2.65"
|
||||
# 0: no drift limit. A press that drifts is still a tap as long as the finger lets go on the tile
|
||||
# (runtime_tiles::event checks where it let go: LVGL keeps the press on the tile and would click it
|
||||
# anywhere), and a quick flick is LVGL's gesture, never a tap (the home_page gesture handler in on_boot).
|
||||
# The CYD keeps a limit because its resistive panel jumps.
|
||||
TOUCH_MOVE_LIMIT_PX: "0"
|
||||
# Shortest contact that counts as a tap; a resistive panel bounces, a capacitive one does not.
|
||||
TOUCH_MIN_PRESS_MS: "20"
|
||||
@@ -226,6 +228,19 @@ esphome:
|
||||
lv_obj_add_flag(id(climate_mode_overlay), LV_OBJ_FLAG_HIDDEN);
|
||||
};
|
||||
runtime_tiles::layout_changed = []() { id(show_tile_page).execute(); };
|
||||
// A quick flick or wipe over the tiles is never a tap (firmware 0.2.65+). LVGL reports it as a gesture that
|
||||
// bubbles up to this page (a tile's slider keeps its own, runtime_tiles::bind): the tap under the finger is
|
||||
// consumed and LVGL waits for the release. No page flip: pages change with the edge swipe (on_update). LVGL
|
||||
// wants speed as well as 50 px of travel, so a firm press that drifts slowly is still a tap. Cards and the
|
||||
// settings page keep their drags; in standby the push still wakes the screen, it only switches nothing.
|
||||
lv_obj_add_event_cb(id(home_page)->obj, [](lv_event_t *) {
|
||||
if (!runtime_tiles::enabled || id(calibration_active) || !id(active_entity).empty() || settings_screen::visible() ||
|
||||
(runtime_tiles::detail_root && !lv_obj_has_flag(runtime_tiles::detail_root, LV_OBJ_FLAG_HIDDEN))) return;
|
||||
cyd::touch_guard.consume();
|
||||
ESP_LOGI("touch", "flick: no tap");
|
||||
if (id(display_dimmed)) return;
|
||||
if (auto *input = lv_indev_active()) lv_indev_wait_release(input);
|
||||
}, LV_EVENT_GESTURE, nullptr);
|
||||
// Camera images (firmware 0.2.57+): the two online_images and the alert's frame.
|
||||
// set_url() forgets the ETag, so it is only called for a new link: an unchanged picture then answers 304.
|
||||
runtime_tiles::camera_full.load = [](const std::string &url) {
|
||||
@@ -1616,6 +1631,9 @@ display:
|
||||
|
||||
lvgl:
|
||||
id: screen_lvgl
|
||||
# The theme's font for text without a font of its own. Every label names its font, so this only keeps
|
||||
# ESPHome from building LVGL's Montserrat 14 for nothing (firmware 0.2.65+).
|
||||
default_font: sublabel
|
||||
on_draw_start:
|
||||
- lambda: 'id(rendered_frames)++;'
|
||||
displays:
|
||||
@@ -2467,7 +2485,9 @@ lvgl:
|
||||
pressed:
|
||||
styles: paint_page_pressed
|
||||
bg_opa: COVER
|
||||
on_short_click:
|
||||
# on_click: LVGL sends no short click after a press of 400 ms, so a firm or slow press did nothing
|
||||
# (firmware 0.2.65+). The bar has no hold of its own; accept_repeat still drops bounce and a swipe.
|
||||
on_click:
|
||||
- if:
|
||||
condition:
|
||||
lambda: 'return cyd::touch_guard.accept_repeat(millis(), 11);'
|
||||
@@ -2508,7 +2528,7 @@ lvgl:
|
||||
pressed:
|
||||
styles: paint_page_pressed
|
||||
bg_opa: COVER
|
||||
on_short_click:
|
||||
on_click:
|
||||
- if:
|
||||
condition:
|
||||
lambda: 'return cyd::touch_guard.accept_repeat(millis(), 12);'
|
||||
@@ -3682,6 +3702,9 @@ lvgl:
|
||||
clickable: true
|
||||
on_click:
|
||||
- script.execute: wake_display
|
||||
# A page that is one full tile switching something on or off switches with this push as well
|
||||
# (firmware 0.2.65+, runtime_tiles::wake_tap); on every other page the first touch only wakes.
|
||||
- lambda: 'runtime_tiles::wake_tap();'
|
||||
|
||||
- id: touch_cal_page
|
||||
styles: paint_page_soft
|
||||
|
||||
Reference in New Issue
Block a user