1a6308aba7
A test and code-analysis round of 0.2.72 to 0.2.76 (suites at every tag, sanitizers, ESP32 and GitHub builds, host harnesses on both boards, the editor in a browser, best practice checked against ESPHome, LVGL, Home Assistant and Vue) found these, fixed here with Max's choices for the product questions: - Firmware 0.2.65: the second hand of a single analog clock moves again; on a page that is one full on/off tile the waking push also switches it; on the Guition a flick is never a tap and a finger that slides off a tile doesn't tap it; Previous/Next react to a firm press; the same Go to page tile may sit on several pages; a layout the screen has no memory for is refused instead of crashing; 64-bit redraw mask for 48 tiles; Montserrat 14 no longer built. - App: Save refuses a layout too long for one message or too big for eight pages; an offline screen keeps its firmware version from the device registry; HA refusals reach the editor; 128 KB requests; changelog out of the live stream; cached hashed assets; tini as init and a clean stop; changelog parsing without asterisks or crashes. - Editor: clicking the open screen keeps unsaved edits, edits during a save stay unsaved, a Page row and phone dragging to other pages, repeated page tiles, limits from the server, HA's error messages, a type-checked build. - tools/check.sh + GitHub Actions + a CYD flash budget; docs match 48 tiles and the new editor. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
114 lines
8.0 KiB
Python
114 lines
8.0 KiB
Python
import re
|
|
import sys
|
|
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
sys.path.insert(0, str(ROOT / 'screen_manager/app'))
|
|
sys.path.insert(0, str(ROOT / 'tests'))
|
|
import test_portal
|
|
import tile_icons
|
|
from core import discover, packets, state_message, validate_layout
|
|
|
|
HEADER = (ROOT / 'components/smart_display/runtime_tiles.h').read_text()
|
|
|
|
class IconSetTests(unittest.TestCase):
|
|
def test_set_is_complete_and_carried_by_every_icon_font(self):
|
|
self.assertEqual(len(tile_icons.ICONS), 150)
|
|
self.assertTrue(any(group == 'Media and music' and len(icons) >= 20 for group, icons in tile_icons.GROUPS))
|
|
self.assertEqual(len(set(tile_icons.GLYPHS.values())), len(tile_icons.GLYPHS))
|
|
for code in tile_icons.GLYPHS.values():
|
|
self.assertRegex(code, r'^F[0-9A-F]{4}$')
|
|
wanted = [f'\\U000{code}' for code in tile_icons.GLYPHS.values()]
|
|
for name in ('home-like-2432s028.yaml', 'guition-4848s040.yaml', 'packages/cyd.yaml', 'packages/guition.yaml'):
|
|
text = (ROOT / name).read_text()
|
|
fonts = re.findall(r'materialdesignicons-webfont\.ttf["\']\n id: (\w+)\n size: \d+\n bpp: 4\n glyphs: (.*)\n', text)
|
|
self.assertEqual([font for font, _ in fonts], ['materialdesign_icons', 'materialdesign_icons_mini', 'materialdesign_icons_big', 'watch_icon'], name)
|
|
self.assertTrue(fonts[0][1].startswith('&tile_icons ') and all(g == '*tile_icons' for font, g in fonts[1:] if font != 'materialdesign_icons_big'), name)
|
|
block = text.split('glyphs: &tile_icons ', 1)[1].split('\n\n', 1)[0]
|
|
self.assertEqual(re.findall(r'- "(\\U000F[0-9A-F]{4})"', block), wanted, name)
|
|
# The big font of the full-page card (firmware 0.2.62+) carries the subset the screen draws on its own.
|
|
self.assertEqual(fonts[2][1].split(' #')[0].strip(), '&tile_icons_big', name)
|
|
big = text.split('glyphs: &tile_icons_big', 1)[1].split('\n\n', 1)[0]
|
|
self.assertEqual(re.findall(r'- "(\\U000F[0-9A-F]{4})"', big), [f'\\U000{tile_icons.GLYPHS[n]}' for n in tile_icons.BIG_GLYPHS], name)
|
|
self.assertNotIn('MDI_GLYPH', text, name)
|
|
self.assertTrue((ROOT / 'web/src/assets/tile-icons.woff').exists())
|
|
|
|
def test_firmware_name_table_mirrors_the_set(self):
|
|
header = (ROOT / 'components/smart_display/tile_icon_names.h').read_text()
|
|
self.assertIn('GENERATED by tools/generate_icons.py', header)
|
|
entries = re.findall(r'^ \{"([a-z0-9-]+)", 0x(F[0-9A-F]{4})\},$', header, re.M)
|
|
self.assertEqual(dict(entries), tile_icons.GLYPHS)
|
|
self.assertEqual(len(entries), len(tile_icons.GLYPHS))
|
|
|
|
def test_every_glyph_the_firmware_draws_is_in_the_set(self):
|
|
sources = [HEADER] + [(ROOT / name).read_text().split('glyphs: &tile_icons', 1)[0] for name in ('home-like-2432s028.yaml', 'guition-4848s040.yaml')]
|
|
used = {code.upper() for source in sources for code in re.findall(r'\\U000(F[0-9A-Fa-f]{4})', source)}
|
|
self.assertLessEqual(used, set(tile_icons.GLYPHS.values()))
|
|
|
|
def test_editor_predictions_mirror_the_firmware(self):
|
|
body = HEADER.split('inline const char *icon_for(const Tile &tile) {', 1)[1].split('\n}', 1)[0]
|
|
native = {}
|
|
for domains, code in re.findall(r'if \((d == "\w+"(?: \|\| d == "\w+")*)\) return "\\U000(F[0-9A-F]{4})";', body):
|
|
for domain in re.findall(r'"(\w+)"', domains):
|
|
native[domain] = code
|
|
# The built-in cards pick per entity, not per domain: a clock, the settings page or a page to go to.
|
|
settings, page, clock = re.search(
|
|
r'if \(d == "screen"\) return tile\.is_settings\(\) \? "\\U000(F[0-9A-F]{4})" : tile\.is_page\(\) \? "\\U000(F[0-9A-F]{4})" : "\\U000(F[0-9A-F]{4})";', body).groups()
|
|
builtin = {entity: tile_icons.GLYPHS[name] for entity, name in tile_icons.BUILTIN_TILES.items()}
|
|
self.assertEqual({'screen.settings': settings, 'screen.clock': clock, **{f'screen.page_{n}': page for n in range(1, 9)}}, builtin)
|
|
self.assertEqual(tile_icons.editor()['builtin'], builtin)
|
|
self.assertEqual(tile_icons.GLYPHS[tile_icons.DEFAULTS['screen']], clock)
|
|
expected = {domain: tile_icons.GLYPHS[name] for domain, name in tile_icons.DEFAULTS.items() if domain != 'screen'}
|
|
self.assertEqual(native, expected)
|
|
self.assertIn(f'return "\\U000{tile_icons.GLYPHS[tile_icons.FALLBACK]}";', body)
|
|
weather = HEADER.split('inline const char *weather_icon(const std::string &condition) {', 1)[1].split('\n}', 1)[0]
|
|
for state, name in tile_icons.WEATHER.items():
|
|
self.assertRegex(weather, rf'condition == "{re.escape(state)}"[^\n]*return "\\U000{tile_icons.GLYPHS[name]}";')
|
|
editor = tile_icons.editor()
|
|
self.assertEqual(sum(len(group['icons']) for group in editor['groups']), 150)
|
|
self.assertIn(f'"\\U000{editor["sun"]["above_horizon"]}" : "\\U000{editor["sun"]["below_horizon"]}"', HEADER)
|
|
|
|
class IconOptionTests(unittest.IsolatedAsyncioTestCase):
|
|
def test_validation_accepts_the_set_and_auto_only(self):
|
|
for value in ('auto', 'lamp', 'spotify', 'speaker'):
|
|
layout = validate_layout({'title': 'Home', 'tiles': [{'entity': 'media_player.a', 'options': {'icon': value}}]})
|
|
self.assertEqual(layout['tiles'][0]['options']['icon'], value)
|
|
for value in ('mdi:lamp', 'F06B5', 'weather-fog', 'unknown', '', None, 42, ['lamp']):
|
|
with self.assertRaises(ValueError):
|
|
validate_layout({'title': 'Home', 'tiles': [{'entity': 'light.a', 'options': {'icon': value}}]})
|
|
|
|
def test_wire_carries_the_codepoint_chosen_or_from_home_assistant(self):
|
|
states = {'light.a': {'state': 'on', 'attributes': {'icon': 'mdi:floor-lamp'}},
|
|
'light.b': {'state': 'on', 'attributes': {'icon': 'mdi:not-in-the-set'}},
|
|
'light.c': {'state': 'on', 'attributes': {}}}
|
|
chosen = state_message(0, {'entity': 'light.a', 'name': '', 'options': {'icon': 'lamp', 'tap': 'toggle'}}, states)
|
|
self.assertEqual(chosen['o'], {'tap': 'toggle', 'icon': 'F06B5'})
|
|
automatic = state_message(0, {'entity': 'light.a', 'name': '', 'options': {'icon': 'auto'}}, states)
|
|
self.assertEqual(automatic['o'], {'icon': 'F08DD'})
|
|
self.assertEqual(state_message(0, {'entity': 'light.a', 'name': ''}, states)['o'], {'icon': 'F08DD'})
|
|
self.assertNotIn('o', state_message(0, {'entity': 'light.b', 'name': ''}, states))
|
|
self.assertNotIn('o', state_message(0, {'entity': 'light.c', 'name': ''}, states))
|
|
self.assertEqual(state_message(0, {'entity': 'light.c', 'name': '', 'options': {'icon': 'auto'}}, states)['o'], {})
|
|
packets(chosen)
|
|
|
|
def test_discovery_reports_home_assistant_icons_the_screen_can_draw(self):
|
|
states = {'light.a': {'state': 'on', 'attributes': {'icon': 'mdi:chandelier'}}, 'light.b': {'state': 'off', 'attributes': {'icon': 'hass:x'}}}
|
|
_, entities = discover([{'entity_id': 'light.a'}], states, [], [])
|
|
self.assertEqual({e['id']: e['icon'] for e in entities}, {'light.a': 'F1793', 'light.b': None})
|
|
|
|
async def test_old_editor_preserves_icon_and_explicit_auto_clears(self):
|
|
with tempfile.TemporaryDirectory() as tmp:
|
|
m = test_portal.ManagerTests().setup_manager(Path(tmp) / 'screens.json')
|
|
m.save('text.screen', {'title': 'Home', 'tiles': [{'entity': 'light.a', 'options': {'icon': 'spotify'}}]})
|
|
m.save('text.screen', {'title': 'Home', 'tiles': [{'entity': 'light.a', 'options': {'inline': 'none'}}]})
|
|
self.assertEqual(m.layouts['text.screen']['tiles'][0]['options'], {'inline': 'none', 'icon': 'spotify'})
|
|
await m.sync_one('text.screen', m.layouts['text.screen'])
|
|
self.assertEqual(m.ha.messages[1][1]['o']['icon'], 'F04C7')
|
|
m.save('text.screen', {'title': 'Home', 'tiles': [{'entity': 'light.a', 'options': {'icon': 'auto'}}]})
|
|
self.assertEqual(m.layouts['text.screen']['tiles'][0]['options']['icon'], 'auto')
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|